Skip to content

Enable integration tests in build-script-helper.py #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2021
Merged

Enable integration tests in build-script-helper.py #511

merged 2 commits into from
Mar 2, 2021

Conversation

porglezomp
Copy link
Contributor

This will enable the swift build-script test runs to get a more complete run—"enable integration tests" seems in-line with the scope of other projects test runs.

@porglezomp porglezomp requested review from edymtt and artemcm February 25, 2021 20:12
@cltnschlosser
Copy link
Contributor

Pretty sure the only integration tests we have are lit tests which also requires SWIFT_DRIVER_LIT_DIR to be set. These aren't passing yet, so don't enable them for swift PRs if it's going to break the build.

@porglezomp
Copy link
Contributor Author

Hm, are there no other integration tests at all? I was planning on adding the SWIFT_DRIVER_LIT_DIR separately while I start getting those passing. This is part of the lead-up work to getting those tests enabled for PR testing.

@porglezomp
Copy link
Contributor Author

@swift-ci please test

@porglezomp
Copy link
Contributor Author

Added a --lit-test-dir flag that will forward to the environment variable. Since nothing passes this flag yet, it won't impact CI runs.

@porglezomp
Copy link
Contributor Author

@swift-ci please test

shahmishal
shahmishal reviewed Mar 1, 2021
View reviewed changes
@porglezomp porglezomp force-pushed the build-script-test-swift-driver branch from 50943bf to 4733a8c Compare March 1, 2021 21:07
@porglezomp porglezomp requested a review from shahmishal March 1, 2021 21:08
@porglezomp
Copy link
Contributor Author

@swift-ci please test and merge

@edymtt
Copy link
Contributor

edymtt commented Mar 1, 2021

Would it be possible to also run Swift PR testing (smoketest and toolchain)?
This can be done by using an empty PR against the Swift repo, e.g. swiftlang/swift#34782
See also https://github.com/apple/swift/blob/main/docs/ContinuousIntegration.md#cross-repository-testing

edymtt
edymtt reviewed Mar 1, 2021
View reviewed changes
Utilities/build-script-helper.py
@@ -191,6 +191,10 @@ def handle_invocation(args):
test_args += ['-Xswiftc', '-enable-testing']
if should_test_parallel():
test_args += ['--parallel']
# The test suite consults these variables to control what tests get run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(optional) The comment could expand on why in this situation it's ok to opt in into those tests (basically the first part of the PR description)

@porglezomp
Copy link
Contributor Author

@swift-ci please test

@porglezomp porglezomp merged commit b7fa6e8 into swiftlang:main Mar 2, 2021
@porglezomp porglezomp deleted the build-script-test-swift-driver branch March 2, 2021 00:40
@porglezomp porglezomp mentioned this pull request Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edymtt edymtt edymtt approved these changes

@shahmishal shahmishal shahmishal approved these changes

@artemcm artemcm artemcm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@porglezomp @cltnschlosser @edymtt @shahmishal @artemcm