Skip to content

[build-script] Pass --lit-test-dir while testing swift-driver #36222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

porglezomp
Copy link
Contributor

@porglezomp porglezomp commented Mar 2, 2021

This passes --lit-test-dir to the swift driver's build-script-helper, which allows it to run Swift lit tests as part of its test suite. This shouldn't be merged until we're ready for CI to run the Driver lit tests from swift-driver.

This uses the flag added in swiftlang/swift-driver#511

rdar://73769164

@porglezomp porglezomp requested review from shahmishal and artemcm March 2, 2021 02:09
@shahmishal
Copy link
Member

@swift-ci smoke test

@porglezomp
Copy link
Contributor Author

Please test with following PR:
swiftlang/swift-driver#518

@swift-ci please smoke test macOS platform

@porglezomp porglezomp marked this pull request as ready for review March 2, 2021 22:02
@shahmishal
Copy link
Member

Please test with following PR:
swiftlang/swift-driver#518

@swift-ci please test windows

Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@porglezomp porglezomp merged commit b64bd95 into swiftlang:main Mar 2, 2021
@porglezomp porglezomp deleted the swift-driver-lit-tests branch March 2, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants