Skip to content

Use library search group when linking statically #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2021

Conversation

drexin
Copy link
Contributor

@drexin drexin commented Mar 19, 2021

Port of this PR: swiftlang/swift#36356

@drexin
Copy link
Contributor Author

drexin commented Mar 19, 2021

@swift-ci test

@drexin
Copy link
Contributor Author

drexin commented Mar 22, 2021

@swift-ci test macos

@owenv
Copy link
Contributor

owenv commented Mar 23, 2021

Should we pull object file and bitcode inputs out of the linker group on the command line? I think this is only necessary for certain autolink inputs, and the performance impact might be significant.

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a change to testLinking analogous to the one made to linker-args-order-linux.swift to make sure the command line looks right when statically linking?

@drexin
Copy link
Contributor Author

drexin commented Mar 23, 2021

@swift-ci test

@drexin
Copy link
Contributor Author

drexin commented Mar 23, 2021

@artemcm done

@drexin drexin force-pushed the wip-static-linking branch from f1d46ed to 10675b8 Compare March 23, 2021 20:10
@drexin
Copy link
Contributor Author

drexin commented Mar 23, 2021

@swift-ci test

@drexin drexin merged commit 901e1e8 into swiftlang:main Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants