[Driver] Use library search group when linking statically

[drexin]

Fixes rdar://75099393

When statically linking, we sometimes run into circular dependencies (e.g. Foundation and CoreFoundation). Using library search groups resolves linker issues in these cases.

[drexin]

@swift-ci smoke test

[tomerd]

@drexin @beccadax once merged, we need to bring this into 5.4 branch as well

[beccadax]

This looks okay from a driver implementation perspective.

I'm not very familiar with the linker feature you're using, but the man page seems to recommend against using it very aggressively:

Using this option has a significant performance cost. It is best to use it only when there are unavoidable circular references between two or more archives.

Do we definitely need to cover everything being added here in a library search group, or can we limit it somehow?

[beccadax]

(I'll approve on the assumption that the list is indeed minimal.)

[drexin]

@beccadax Thanks. This will only affect static linking and the list of the dependencies will be whatever swift-autolink-extract produces. I would definitely prefer this to only be applied when necessary, but it's not really possible to figure this out automatically.

[artemcm]

@drexin,
Could you please make an analogous change in the new driver?

This should be a good starting point:
https://github.com/apple/swift-driver/blob/main/Sources/SwiftDriver/Jobs/GenericUnixToolchain%2BLinkerSupport.swift#L46

[drexin]

@artemcm Yes, I was planning to do that. Thanks for the ping.