Verify module interfaces generated from emit-module jobs #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
The Verify job was previously only added after merge-module jobs.
xymus
force-pushed
the
emit-module-verify
branch
from
b510621 to
331d2fe
Compare
|
@swift-ci test |
artemcm
approved these changes
Apr 23, 2021
| @@ -253,9 +257,9 @@ extension Driver { | |||
| addJob: (Job) -> Void, | |||
| addJobOutputs: ([TypedVirtualPath]) -> Void, | |||
| emitModuleTrace: Bool | |||
| ) throws { | |||
| ) throws -> Job? { | |||
There was a problem hiding this comment.
Just because the name states the plural Jobs, and we may be adding multiple (with backend jobs), it's worth a comment to explain exactly which job this function is going to return.
| addJobOutputs: addJobOutputs, | ||
| emitModuleTrace: loadedModuleTracePath != nil) | ||
| emitModuleTrace: loadedModuleTracePath != nil) { | ||
| try addVerifyJobs(mergeJob: compileJob, addJob: addJobAfterCompiles) |
There was a problem hiding this comment.
Nit: it may be time to re-name this argument name from mergeJob to something that better reflects that this can be any interface-producing job.
beccadax
approved these changes
Apr 24, 2021
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify interfaces generated by single compile jobs and emit-module jobs. The verify job was previously only added after merge-module jobs which is more prone to generate broken swift interfaces.