[5.5] Verify module interfaces generated from emit-module jobs #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The verify job was previously only added after merge-module jobs. rdar://77623534
|
@swift-ci Please test |
|
@swift-ci Please nominate Does that work here? |
airspeedswift
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #615.
Apply the flag
-verify-emitted-module-interfaceto all jobs emitting module files, fixing a hole that limited it to merge-module builds. This effectively makes the driver verify all produced swiftinterfaces in all build modes as expected when the flag is passed.Origination: This was likely fine in the old driver and never fully implemented in the new driver.
Scope: Affects projects explicitly using the
-verify-emitted-module-interfaceflag.rdar://77623534