Move forwarding to non-compiler driver kinds into the planning stage #62
Conversation
| var commandLine: [Job.ArgTemplate] = driverKind.usageArgs | ||
| try commandLine.append(contentsOf: parsedOptions.allArguments()) | ||
| return Job(kind: .forwarding, | ||
| tool: .absolute(try toolchain.getToolPath(.swiftCompiler)), |
There was a problem hiding this comment.
This is an interesting choice. In many of these cases, we're not actually executing the Swift compiler, but some other tool. Should we look up that tool by name, rather than having the "tool" effectively be ignored?
There was a problem hiding this comment.
I think this is the way to go. It'll be a lot simpler once the compiler binary is renamed to swift-frontend though. That'll allow us to avoid needing to add -frontend or -modulewrap when invoking it with the right tool name. This PR isn't an important change, so I might just hold off on landing it until then.
There was a problem hiding this comment.
Sounds like I really need to finish off that compiler binary rename. Thanks for the nudge ;)
|
@swift-ci please test |
This is a continuation of #58 which moves forwarding into jobs created during build planning.