Add -no-whole-module-optimization flag #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors this change swiftlang/swift#29362
keith
commented
Jan 27, 2020
| @@ -721,7 +721,7 @@ extension Driver { | |||
| // Some output flags affect the compiler mode. | |||
| if let outputOption = parsedOptions.getLast(in: .modes) { | |||
| switch outputOption.option { | |||
| case .emitPch, .emitImportedModules, .indexFile: | |||
There was a problem hiding this comment.
Because this was here previously all the logic below around indexFile appeared to have never worked. This fixed this and added a test for it
There was a problem hiding this comment.
Whoops, thank you! -index-file hasn't really be implemented or tested.
DougGregor
approved these changes
Jan 27, 2020
| @@ -721,7 +721,7 @@ extension Driver { | |||
| // Some output flags affect the compiler mode. | |||
| if let outputOption = parsedOptions.getLast(in: .modes) { | |||
| switch outputOption.option { | |||
| case .emitPch, .emitImportedModules, .indexFile: | |||
There was a problem hiding this comment.
Whoops, thank you! -index-file hasn't really be implemented or tested.
|
@swift-ci please test |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors this change swiftlang/swift#29362