Add -no-whole-module-optimization

[keith]

This adds an argument to allow negating -whole-module-optimization.
This is useful for cases where it's easier to add an extra flag to your
swiftc invocation rather than removing the original one.

[varungandhi-apple]

@swift-ci please smoke test

[keith]

Thanks for the review, updated accordingly!

[varungandhi-apple]

@swift-ci please smoke test

[varungandhi-apple]

Also, going forward, in case you need someone to review/kick off tests, please feel free to @ me or someone else. Worst case, they ping someone else who might be better suited to do the review. It is not great if people hang around waiting for a reviewer and eventually have the patch fall through the cracks.

[keith]

Great thank you!

[keith]

Should i submit a similar change to the new driver project as well?

[varungandhi-apple]

Sure, good thing that you suggested that! I totally forgot about it 😅.

[varungandhi-apple]

For that one, you should probably @ CodaFi or brentdax for review since they are more familiar with the code.

[keith]

Another thought, should I make -no-wmo too? I assume that would be as easy as adding the flag to Options.td and then it would "just work" (with a test)

[varungandhi-apple]

I don't follow. You already added -no-whole-module-optimization... is the (only) benefit of having -no-wmo is that it is shorter to type? In that case, I don't think you should add that.

[keith]

Yea just to have the analogy of having both flags

[keith]

(Since -wmo exists)

[keith]

Here's what the change would be #29476 no strong preference if you don't feel like it's necessary!

[keith]

Here's the swift-driver PR for this change swiftlang/swift-driver#64