Verify usage of -o arguments in multi-threading mode.
#711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reading mode Causing the behavior to be analagous to the Legacy driver's here: https://github.com/apple/swift/blob/main/lib/Driver/Driver.cpp#L2415 Otherwise, this isn't a supported flow and leads to driver crashes downstream. Resolves rdar://79171618
|
@swift-ci please test |
cltnschlosser
approved these changes
Jun 11, 2021
|
Thanks @cltnschlosser ! |
davidungar
reviewed
Jun 16, 2021
| @@ -24,6 +24,7 @@ public struct Driver { | |||
| case relativeFrontendPath(String) | |||
| case subcommandPassedToDriver | |||
| case integratedReplRemoved | |||
| case cannotSpecify_OForMultipleOutputs | |||
There was a problem hiding this comment.
It might help users to list the outputs in here, and print them with the error message.
davidungar
reviewed
Jun 16, 2021
| @@ -191,7 +191,8 @@ public final class MultiJobExecutor { | |||
| to producerMap: inout [VirtualPath.Handle: Int] | |||
| ) { | |||
| for output in job.outputs { | |||
| if let otherJobIndex = producerMap.updateValue(index, forKey: output.fileHandle) { | |||
| if output.file != .standardOutput, | |||
There was a problem hiding this comment.
A comment explaining why the error is skipped for .standardOutput could help here.
There was a problem hiding this comment.
Also, the updateValue gets skipped. Maybe producerMap should exclude stdouts? Does it already?? Is there a comment on the var??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Causing the behavior to be analagous to the Legacy driver's here:
https://github.com/apple/swift/blob/main/lib/Driver/Driver.cpp#L2415
Otherwise, this isn't a supported flow and leads to driver crashes downstream.
Also ensure that we do not perform the check that ensures the same output is not produced more than once for standard-out outputs. This allows things like
-emit-irto actually function with-wmo -num-threadsand be output correctly.