[5.5] Produce an error when multiple -o options are specified in multi-threading mode
#713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reading mode Causing the behavior to be analagous to the Legacy driver's here: https://github.com/apple/swift/blob/main/lib/Driver/Driver.cpp#L2415 Otherwise, this isn't a supported flow and leads to driver crashes downstream. Resolves rdar://79171618
|
@swift-ci please test |
nkcsgexi
approved these changes
Jun 14, 2021
owenv
approved these changes
Jun 15, 2021
davidungar
approved these changes
Jun 16, 2021
There was a problem hiding this comment.
Sorry I didn't see this request and #711 sooner.
I looked over 711 and had a few minor thoughts, nothing to block merging. Possibilities for the future.
airspeedswift
approved these changes
Jun 16, 2021
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.5 Cherry-pick of #711
Causing the behavior to be analagous to the Legacy driver's here:
https://github.com/apple/swift/blob/main/lib/Driver/Driver.cpp#L2415
Otherwise, this isn't a supported flow and leads to driver crashes downstream.
Resolves rdar://79171618