Skip to content

Disable explicit module builds test #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jun 22, 2021

It's failing in CI for some as-yet-undetermined reason.

rdar://79594631

It's failing in CI for some as-yet-undetermined reason.

rdar://79594631
@CodaFi CodaFi requested a review from artemcm June 22, 2021 04:03
@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 22, 2021

@swift-ci test

The linker on Xcode 13 can no longer find libObjC without an -sdk
argument on macOS.
@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 22, 2021

@swift-ci test

@artemcm artemcm merged commit e9aafba into swiftlang:main Jun 22, 2021
@CodaFi CodaFi deleted the ive-been-working-on-the-building branch June 22, 2021 18:21
artemcm added a commit to artemcm/swift-driver that referenced this pull request Jun 22, 2021
…e test.

Recent changes that introduced `-clang-target` have introduced a conflict with how explicit module builds work. We need to address this, but in the meantime, re-enable the test with `-disable-clang-target`.

Resolves rdar://79594631
artemcm added a commit that referenced this pull request Jun 23, 2021
Revert "Disable explicit module builds test #725" and fix the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants