Skip to content

Revert "Disable explicit module builds test #725" and fix the test. #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jun 22, 2021

Recent changes that introduced -clang-target have introduced a conflict with how explicit module builds work. We need to address this, but in the meantime, re-enable the test with -disable-clang-target.

Resolves rdar://79594631

…e test.

Recent changes that introduced `-clang-target` have introduced a conflict with how explicit module builds work. We need to address this, but in the meantime, re-enable the test with `-disable-clang-target`.

Resolves rdar://79594631
@artemcm artemcm requested review from CodaFi and nkcsgexi June 22, 2021 21:43
@artemcm
Copy link
Contributor Author

artemcm commented Jun 22, 2021

@swift-ci please test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@artemcm artemcm merged commit d47a1f2 into swiftlang:main Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants