Jobs: do not inject the swiftautolink file into archives #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been observed that a static library may sometimes contain the autolink extracted rules. This causes autolink-extract to not be able to process the archive as a dependency, causing a build failure.
|
@swift-ci please test |
|
Would be good to get this in. I'm putting together a pull to download the latest 5.5 snapshots and test them on my daily Android CI, and I currently have to disable using this new Swift driver because of this bug. |
|
@DougGregor, would be good to get this in, or using Swift static libraries on linux will regress with the 5.5 release. I'd like to get #784 in too. |
|
@artemcm, can we get this in too? This currently breaks building the Foundation static libraries for Android, when it tries to link |
artemcm
approved these changes
Aug 30, 2021
|
Ping @airspeedswift, would be good to get this in. |
|
Pinging @airspeedswift, can we get this into the point release? |
tkremenek
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been observed that a static library may sometimes contain the
autolink extracted rules. This causes autolink-extract to not be able
to process the archive as a dependency, causing a build failure.