Skip to content

[5.5] SR-14796: Don't lose '-sdk /' when dropping the trailing slash #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2021
Merged

[5.5] SR-14796: Don't lose '-sdk /' when dropping the trailing slash #784

merged 1 commit into from
Oct 27, 2021

Conversation

finagolfin
Copy link
Member

Cherry-pick of #776

  • Explanation: This was a regression compared to the old C++ Driver, where this new Driver can no longer deal with a passed-in SDK path of /.
  • Scope: Only affects the single-character SDK path of /, allowing it again.
  • Risk: Almost none
  • Testing: Passes the new test, as indicated in the upstream pull.
  • Reviewer: @drexin

@finagolfin
SR-14796: Don't lose '-sdk /' when dropping the trailing slash
a2df97d 
This was a regression compared to the old C++ Driver.
@finagolfin finagolfin requested a review from a team as a code owner August 3, 2021 04:51
@finagolfin finagolfin changed the title SR-14796: Don't lose '-sdk /' when dropping the trailing slash [5.5] SR-14796: Don't lose '-sdk /' when dropping the trailing slash Aug 3, 2021
@drexin
Copy link
Contributor

drexin commented Aug 3, 2021

@swift-ci test

@finagolfin
Copy link
Member Author

Ping, would be good to get this and #777 in, so I can drop workarounds like this when building the Swift 5.5 toolchain.

@finagolfin finagolfin mentioned this pull request Aug 19, 2021
Merged
artemcm
artemcm approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
cc @airspeedswift

@drexin
Copy link
Contributor

drexin commented Aug 30, 2021

@swift-ci please nominate

@finagolfin
Copy link
Member Author

@artemcm, I'd like to get this simple fix in too.

@tkremenek tkremenek merged commit 86c54da into swiftlang:release/5.5 Oct 27, 2021
@finagolfin finagolfin deleted the sdk-path branch November 2, 2021 17:09
@finagolfin finagolfin mentioned this pull request Aug 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkremenek tkremenek tkremenek approved these changes

@artemcm artemcm artemcm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@finagolfin @drexin @tkremenek @artemcm