-
Notifications
You must be signed in to change notification settings - Fork 207
Sanitization facility #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite the README to be more clear about the goals and plans for the project
Drop hanging sentence
Add a diagnostic verifier to XCTest
This changes the behavior for several uses of ParsedOptions to go through lookup tables from canonical option spellings to the list of matched parsed options, in order.
…e-again [Options] Use a prefix trie for option matching
@AminPlusPlus It seems you may have pushed the wrong branch. Would you be able to push the correct changes to this branch? |
let positiveIndexOpt = parsedOptions.lastIndex { $0.option == positive } | ||
let negativeIndexOpt = parsedOptions.lastIndex { $0.option == negative } | ||
let positiveOpt = lookup(positive).last | ||
let negativeOpt = lookup(positive).last |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lookup(negative)
@AminPlusPlus Quick Ping about this branch, can you push the relevant changes? |
@harlanhaskins For now, I don't have any changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me find fixme, and implement it