Relative rsp files #82
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on, fail on invalid rsp files
zienag
force-pushed
the
relative_rsp_file_2
branch
from
a736d79 to
a59e2c3
Compare
zienag
commented
Mar 6, 2020
| XCTAssert(diags.diagnostics.first!.description.contains("is recursively expanded")) | ||
| // FIXME: Error message about nonexistent response file could be improved | ||
| XCTAssertEqual(diags.diagnostics[1].description, "noEntry") |
There was a problem hiding this comment.
Is it better to change it in tools-support-core or just transform it in swift-driver code?
|
The Swift project moved the default branch to More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow relative paths for rsp file, skip forwarded args in rsp expansion, fail on invalid rsp files.
Should go after #73
The solution for skipping
-Xblabla @SOMETHINGis rather fragile, but I didn't find any better without major changes. One way to do it might be to add option attribute, something like "argument escape" (as -Xblabla is similar to escaping)