-
Notifications
You must be signed in to change notification settings - Fork 206
Make swift driver friendlier to relative paths #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this looks like it should make path management a lot more consistent!
@swift-ci test |
@zienag sorry for taking so long to come back to this. It looks one of the response file tests is failing on CI |
Hmm, that is unfortunately non trivial bug: given arguments
Do you know any code/place that works with |
Meanwhile, I'll remove changes associated with response file from this pr, as extensions I've added are needed by other prs |
dae1841
to
eef0bfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunate that you had to undo some of the work for response files, but this looks good!
@zienag unfortunately I don't have a good idea about how to handle -X... arguments with response files. This might cause problems when we eventually migrate to swift-argument-parser too. In the meantime, the rest of this change will still be really helpful though! |
@swift-ci test |
1 similar comment
@swift-ci test |
Looks like the checks are all passing now. Thanks @zienag ! |
Add handling for relative paths in output file map path,
resonse file paths, recorded input modification dates.