Skip to content

[Dependency Scanning] Adapt to changes in dependenncy scanner to capture initial PCM arguments #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Sep 22, 2021

The graph coming out of the scanner will already contain an initial set of captured PCM arguments as defined by the initial scanner invocation. This will allow us to skip the batch re-scan at argument sets that are redundant because they were already captured via the initial scan.

@artemcm artemcm requested a review from nkcsgexi September 22, 2021 18:47
@artemcm
Copy link
Contributor Author

artemcm commented Sep 22, 2021

@swift-ci please test

@artemcm
Copy link
Contributor Author

artemcm commented Sep 22, 2021

Corresponding compiler PR that adds the new libSwiftScan entry-points:
swiftlang/swift#39397

@artemcm artemcm force-pushed the ScannerCapturesInitialPCMArgs branch from 49ef5bd to 8c55a56 Compare September 22, 2021 18:52
@artemcm
Copy link
Contributor Author

artemcm commented Sep 22, 2021

@swift-ci please test

@artemcm artemcm merged commit 4f7ea25 into swiftlang:main Sep 23, 2021
@artemcm artemcm deleted the ScannerCapturesInitialPCMArgs branch September 23, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants