Skip to content

[5.5][Dependency Scanning] Adapt to changes in dependency scanner to capture initial PCM arguments #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2021
Merged

[5.5][Dependency Scanning] Adapt to changes in dependency scanner to capture initial PCM arguments #850

merged 1 commit into from
Sep 28, 2021

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Sep 23, 2021

Cherry-pick of #848

  • Explanation: The graph coming out of the scanner will already contain an initial set of captured PCM arguments as defined by the initial scanner invocation. This will allow us to skip the batch re-scan at argument sets that are redundant because they were already captured via the initial scan.
  • Risk: Low

@artemcm artemcm requested a review from nkcsgexi September 23, 2021 20:40
@artemcm artemcm requested a review from a team as a code owner September 23, 2021 20:40
@artemcm
Copy link
Contributor Author

artemcm commented Sep 23, 2021

@swift-ci please test

@artemcm
Copy link
Contributor Author

artemcm commented Sep 28, 2021

@swift-ci please test

@artemcm artemcm merged commit 5d1a843 into swiftlang:release/5.5 Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

@airspeedswift airspeedswift airspeedswift approved these changes

Assignees
No one assigned
Labels
swift 5.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artemcm @nkcsgexi @airspeedswift