ABIChecking: use the always-generated-abi-descriptor to diagnose ABI breakages #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
…breakages rdar://84595482
|
@swift-ci please test |
artemcm
reviewed
Oct 27, 2021
| @@ -41,7 +41,7 @@ public struct Job: Codable, Equatable, Hashable { | |||
| case generateAPIBaseline = "generate-api-baseline" | |||
| case generateABIBaseline = "generate-abi-baseline" | |||
| case compareAPIBaseline = "compare-api-baseline" | |||
| case compareABIBaseline = "compare-abi-baseline" | |||
| case compareABIBaseline = "Check ABI stability" | |||
There was a problem hiding this comment.
nit: this seems to now stand out from the surrounding raw value style, what's the reason for this change?
There was a problem hiding this comment.
This shows up in the build log in a way that's quite different from other task descriptions. We may look into updating other raw values as well.
artemcm
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://84595482