[5.5] ABIChecking: use the always-generated-abi-descriptor to diagnose ABI breakages #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test |
…breakages rdar://84595482
nkcsgexi
force-pushed
the
84595482-5.5-2
branch
from
08ebd52 to
903ef0c
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Explanation: Previously, in order to diagnose ABI breakages, the driver needs to first import the generated Swift interface, which requires us to set up search paths correctly. Since we now generate the ABI descriptor JSON file alongside the Swift module/interface, we should be able to use these JSON files directly without importing the generated Swift interface, bypassing the problem space of setting search paths properly for the ABI checker invocation as a result.
• Scope of Issue: Swift ABI checker
• Origination: Issue found when invoking ABI checker
• Risk: Very Low. Internal Tools only
• Cherry-pick of: #885
• Resolves: rdar://84595482
• Reviewed By: Artem
• Automated Testing: Regression tests updated