Various visibility (and other) cleanup. #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reduce things from public to internal if they don't need to be public, like tests. - Use fileprivate, not private, at file scope. - Reduce some things that were internal to fileprivate or private. - Remove @testable imports as a prerequisite for adding CI, making necessary decls public to access them. - Some other random NFC cleanup.
|
cc @dylansturg |
dylansturg
approved these changes
Feb 3, 2020
aaditya-chandrasekhar
pushed a commit
to val-verde/swift-format
that referenced
this pull request
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change cleans up visibility throughout the code, with the main objectives being:
publicif they don't need to be (e.g., tests).internalthingsprivateorfileprivateif they don't need to be accessed outside the scope/file.fileprivateat file scope instead ofprivate.@testableimports, making someinternalthingspublicto support that change (needed to add swift-format to CI).This also deletes some unused code, mostly helpers that were written to work with nodes/trivia in the phase 1 rules that are no longer needed.