Absorb trailing comma of function call args in grouped exprs. #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there other trailing commas that pose similar problems that we should knock out while we're in here? For example, array/dictionary/tuple literals with element expressions ending in a close break? |
When a trailing comma occurs after an expression that's wrapped in open/close breaks, the comma can be moved to a new line if it happens to exceed the column limit. By marking these as closing delimiters, they're absorbed into the grouped expressions.
dylansturg
force-pushed
the
no_lonely_commas
branch
from
666e9ad to
096078e
Compare
Good point - I reproduced the issue in arrays, dictionaries, tuples and pattern binding. I updated |
allevato
approved these changes
Feb 26, 2020
aaditya-chandrasekhar
pushed a commit
to val-verde/swift-format
that referenced
this pull request
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, these trailing commas could be placed on a new line after the expression because the close break after the expression would fire if the comma landed exactly 1 over the column limit. Now the comma is moved inside of the group and breaks around the expr so that a break inside of the expr fires instead of the close break.