Add String tests from stdlib #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epo) Batch add `String` and `Substring` tests for from stdlib to FCF. These were removed from stldlib in https://github.com/apple/swift/pull/67252/files and swiftlang/swift#67450. These tests were added to test Foundation's `StringProtocol` extension that called into `NSString` API. Now that some of the tests were implemented with Swift natively, they should be made available for FoundationPreview, but we'll track that in a separate PR.
…nctions those localized functions can call into and pass in a locale explicitly for testing.
|
@swift-ci please test |
jmschonfeld
reviewed
Oct 12, 2023
| } | ||
|
|
||
| expectEqual(ComparisonResult.orderedSame, | ||
| "abc".compare("abc", locale: Locale.current)) |
There was a problem hiding this comment.
Should we make this an explicit locale so that the results of this test don't depend on the test host device's locale (in actually, I guess the current locale would probably never actually affect this comparison since they're equal, but might be a good change for correctness' sake?)
There was a problem hiding this comment.
Good catch. Definitely
|
@swift-ci please test |
jmschonfeld
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch add
StringandSubstringtests from stdlib. These were removed from stdlib in https://github.com/apple/swift/pull/67252/files and swiftlang/swift#67450. These tests were added to test Foundation'sStringProtocolextension that called intoNSStringAPI.Now that some of the tests were implemented with Swift natively, they should be made available for FoundationPreview, but we'll track that in a separate PR.