tests: Disable some tests which fail due to problems in Foundation #67450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
Those tests should be part of the Foundation overlay, which is no longer part of the Swift project. rdar://112643333
eeckstein
force-pushed
the
disable-nsstring-tests
branch
from
4131554 to
7f54c63
Compare
|
@swift-ci smoke test |
natecook1000
pushed a commit
to natecook1000/swift
that referenced
this pull request
Aug 1, 2023
tests: Disable some tests which fail due to problems in Foundation
natecook1000
added a commit
that referenced
this pull request
Aug 1, 2023
tests: Disable some tests which fail due to problems in Foundation Co-authored-by: eeckstein <[email protected]>
itingliu
added a commit
to itingliu/swift-foundation
that referenced
this pull request
Oct 12, 2023
…epo) Batch add `String` and `Substring` tests for from stdlib to FCF. These were removed from stldlib in https://github.com/apple/swift/pull/67252/files and swiftlang/swift#67450. These tests were added to test Foundation's `StringProtocol` extension that called into `NSString` API. Now that some of the tests were implemented with Swift natively, they should be made available for FoundationPreview, but we'll track that in a separate PR.
itingliu
added a commit
to swiftlang/swift-foundation
that referenced
this pull request
Oct 19, 2023
* rdar://106770688 (Port test/stdlib/NSStringAPI.swift from the Swift repo) Batch add `String` and `Substring` tests for from stdlib to FCF. These were removed from stldlib in https://github.com/apple/swift/pull/67252/files and swiftlang/swift#67450. These tests were added to test Foundation's `StringProtocol` extension that called into `NSString` API. Now that some of the tests were implemented with Swift natively, they should be made available for FoundationPreview, but we'll track that in a separate PR. * Address review feedback: clean up availability annotations * Remove the need of swizzling current locale. Instead, add internal functions those localized functions can call into and pass in a locale explicitly for testing. * Remove the use of current locale in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those tests should be part of the Foundation overlay, which is no longer part of the Swift project.
rdar://112643333