update fedora setup to follow conventions of other RPM builders #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
changed the title
tomerd
force-pushed
the
refactor/fedora-docker-compose
branch
from
da76aee to
75e9135
Compare
|
@tomerd Can you resolve the merge conflict? cc: @tachoknight for review |
tomerd
force-pushed
the
refactor/fedora-docker-compose
branch
4 times, most recently
from
14da371 to
d521787
Compare
|
needs #85 first (formatting changes) |
shahmishal
approved these changes
Mar 12, 2022
tomerd
force-pushed
the
refactor/fedora-docker-compose
branch
from
d521787 to
639d004
Compare
motivation: consistentcy across RPM builders changes: * add docker-compose setup * update rpmspec to use share metadata * update Dockerfile to use updated rpmspec * update build script to use updated Dockerfile and rpmspec * add readme
tomerd
force-pushed
the
refactor/fedora-docker-compose
branch
from
639d004 to
a5930a5
Compare
|
@tachoknight thoughts? if no further feedback, we'll move forward and get this merged, and can address any future feedback in follow up PRS |
|
@tomerd That looks really slick! I'm all in favor of the changes |
|
@tomerd feel free to merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: consistentcy across RPM builders
changes: