improve RPM spec formatting #85
Merged
+155
−194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: easier to maintain code changes: * sort BuildRequires, Requires and move secions alphabetically * other small formatting fixes like whitespace, etc * remove cmake from fedora BuildRequires since we are builfing it from source * update fedora rawhide path to be more consistent with other fedora locations and rpm builders
tomerd
commented
Mar 11, 2022
| ln -fs %{_libexecdir}/swift/bin/sourcekit-lsp %{buildroot}%{_bindir}/sourcekit-lsp | ||
| ln -fs %{_libexecdir}/swift/%{package_version}/bin/swift %{buildroot}%{_bindir}/swift | ||
| ln -fs %{_libexecdir}/swift/%{package_version}/bin/swiftc %{buildroot}%{_bindir}/swiftc | ||
| ln -fs %{_libexecdir}/swift/%{package_version}/bin/sourcekit-lsp %{buildroot}%{_bindir}/sourcekit-lsp |
There was a problem hiding this comment.
this looks to have been a mistake in the rawhide script
tomerd
commented
Mar 11, 2022
| mv swift-syntax-swift-%{swift_version} swift-syntax | ||
| mv swift-system-%{swift_system_version} swift-system | ||
| mv swift-tools-support-core-swift-%{swift_version} swift-tools-support-core | ||
| mv swift-xcode-playground-support-swift-%{swift_version} swift-xcode-playground-support | ||
| mv Yams-%{yams_version} yams |
There was a problem hiding this comment.
^^ basically sorts the "mv" commands, no functional change
tomerd
commented
Mar 11, 2022
| mv Yams-%{yams_version} yams | ||
|
|
||
| # Ninja | ||
| mv ninja-%{ninja_version} ninja | ||
|
|
There was a problem hiding this comment.
^^ basically sorts the "mv" commands, no functional change
tomerd
commented
Mar 11, 2022
| mv Yams-%{yams_version} yams | ||
|
|
||
| # Ninja | ||
| mv ninja-%{ninja_version} ninja | ||
|
|
There was a problem hiding this comment.
^^ basically sorts the "mv" commands, no functional change
tomerd
commented
Mar 11, 2022
|
|
||
| ExclusiveArch: x86_64 aarch64 | ||
| ExclusiveArch: x86_64 aarch64 |
There was a problem hiding this comment.
^^ basically sorts the Requires and BuildRequires, no functional change
tomerd
commented
Mar 11, 2022
| Requires: ncurses-compat-libs | ||
| Requires: ncurses-devel |
There was a problem hiding this comment.
^^ basically sorts the Requires and BuildRequires, no functional change
tomerd
commented
Mar 11, 2022
| Requires: ncurses-compat-libs | ||
| Requires: ncurses-devel |
There was a problem hiding this comment.
^^ basically sorts the Requires and BuildRequires, no functional change
shahmishal
approved these changes
Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: easier to maintain code
changes: