[SR-7074] Introduce ability to add top level files #1516
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giginet
commented
Mar 3, 2018
|
|
||
| // Add root level files to the project. | ||
| func shouldIgnore(_ path: AbsolutePath) -> Bool { | ||
| return path.basename.hasPrefix(".") |
There was a problem hiding this comment.
I think it is more useful to ignore dotfiles. (like .gitignore or .DS_Store).
How do you think?
There was a problem hiding this comment.
I would like some files to be included like .swiftlint.yml but that might be possible with a different flag such as --include .swiftlint.yml
giginet
changed the title
giginet
changed the title
|
I'll add tests after merging #1517. |
|
@ViktorSimko OK. Could you review #1517 ? |
giginet
changed the title
|
I'm going to add some tests for this feature. |
|
It looks like this bug is dupe of SR-1741 and @ViktorSimko has already done a significant work in PR #1507 to resolve that issue. @giginet, do you mind picking up another starter bug 😊? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement SR-7074.
I introduce the ability to add top level files (like
README.md) to a generated Xcode project.$ swift package generate-xcodeproj