Returns Xcode.Project from generate() #1517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ikesyo After discussion with you, I introduce |
ViktorSimko
approved these changes
Mar 8, 2018
|
Could you review anyone? |
hartbit
reviewed
Apr 10, 2018
Sources/Xcodeproj/generate().swift
Outdated
| /// generated project. All ancillary files will be generated inside of the | ||
| /// .xcodeproj wrapper directory. | ||
| /// wrapper directory is created to the path specified by `xcodeprojPath` | ||
| /// Returns the path of the generated project. All ancillary files will |
There was a problem hiding this comment.
I think this comment needs to be updated to say it returns the project object.
This reverts commit 48c5e3d.
giginet
force-pushed
the
refactor-xcodeproj
branch
from
33b817d to
388faab
Compare
|
@hartbit Sorry for my late response. I've fixed documentation of |
hartbit
reviewed
Apr 30, 2018
Sources/Xcodeproj/generate().swift
Outdated
| @@ -70,10 +72,15 @@ public func generate( | |||
| let extraDirs = try findDirectoryReferences(path: srcroot) | |||
|
|
|||
| /// Generate the contents of project.xcodeproj (inside the .xcodeproj). | |||
| var project: Xcode.Project! | |||
There was a problem hiding this comment.
The pbxproj function could be called here to avoid the IUO.
|
@swift-ci please smoke test |
|
@aciidb0mb3r This LGTM. |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'd like to test generated Xcode Project on XcodeprojTests.
Currently,
Xcodeproj.generatereturns only its path.So we can't investigate contents of the project.
Description
I refactored Xcodeproj related code.
Xcodeproj.generate()returnsXcode.Projectobject.Thanks to this change, we can write tests easily.