[bootstrap] Preemptively add argument for Foundation [AsyncXCTest 3/6] #176
Conversation
|
The README diff seems to remove the --build-tests part of the example invocation. No changes to the script seem to be related to that. Was this removed from the README in error or is that parameter not actually necessary? |
|
@mike-ferris-apple I've decided to make the documentation changes in #177, so I'll remove them from this pull request. As for |
swiftlang/swift-corelibs-xctest#43 will add a dependency between swift-corelibs-xctest and swift-corelibs-foundation. This will necessitate the path to a Foundation build be passed to the SwiftPM bootstrap script. In order to prevent CI from breaking, we'll modify the Swift build script to pass the correct parameters *before* those parameters are actually used. To do that, this commit ensures the bootstrap script accepts the new parameter: "--foundation".
modocache
force-pushed
the
xctest-foundation-arguments
branch
from
ec456c9 to
794bb66
Compare
modocache
changed the title
modocache
changed the title
|
@swift-ci please test |
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
The tests pass! 🎉 @kostiakoval or @mxcl, how do you feel about merging this? It's crucial to delivering asynchronous tests in corelibs-xctest, and I was kind of hoping to merge everything tonight. |
|
LGTM ✋ |
|
@aciidb0mb3r I don't suppose this could be the first pull request you merge? 🙏 |
[bootstrap] Preemptively add argument for Foundation [AsyncXCTest 3/6]
|
@modocache Done! Thanks for your work and sorry for delay. |
|
Thanks!! |
swiftlang/swift-corelibs-xctest#43 will add a dependency between swift-corelibs-xctest and swift-corelibs-foundation. This will necessitate the path to a Foundation build be passed to the SwiftPM bootstrap script. See #177 for details on what this path will be used for.
In order to prevent CI from breaking, we'll modify the Swift build script to pass the correct parameters before those parameters are actually used. To do that, this commit ensures the bootstrap script accepts the new parameter: "--foundation".