[build-script] Build Foundation before XCTest [AsyncXCTest 4/6] #1556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftlang/swift-corelibs-xctest#43 introduces a dependency between XCTest and Foundation. Modify the build script in order to properly build all products: - Build Foundation before XCTest, then link Foundation when building XCTest by using new '--foundation-build-dir' option. - Link Foundation when testing SwiftPM by using new '--foundation' option. - On Linux, ensure Foundation is built when XCTest is.
modocache
changed the title
modocache
changed the title
|
@gribozavr Any thoughts on these changes? Also, could you ask @swift-ci to please test? Thanks! 🙇 |
|
@swift-ci Please test |
|
The tests pass! Any thoughts on the content? Is it acceptable that on Linux |
|
@gribozavr Change looks good to me. Any thoughts? |
|
@gribozavr @tkremenek Thanks for the review! Considering the changes look good and the tests pass, I'm going to go ahead and merge this. 🙇 |
modocache
added a commit
that referenced
this pull request
Mar 8, 2016
…tion [build-script] Build Foundation before XCTest [AsyncXCTest 4/6]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
swiftlang/swift-corelibs-xctest#43 introduces a dependency between XCTest and Foundation. Modify the build script in order to properly build all products:
Resolved bug number: None
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.