Fix versions in documentation #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The unlabeled parameter was added before we allowed string literal convertibles, so really I should make it labeled for this context. |
|
Used #13. Thank you for your time and sorry we used the other patch. |
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
Consistent tense for Compile/Link
sergiocampama
pushed a commit
that referenced
this pull request
Apr 20, 2020
Sync with SwiftPM trunk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Package(url:versions:)requires aRange<Version>as argument, passing aStringto it will fail the package building with this error.Although
Versionitself isStringLiteralConvertible, theRange<Version>is not.Another way to fix it would be something like
.Package(url: "…", versions: "1.0.0"..."1.0.2"). But I guess we'd better to keep it simple for demonstration purpose.See #13 and #17 as well.