Add header search path for c modules during xcodeproj gen #226
Conversation
| for header in headerPaths { | ||
| headerPathValue += "\"\(header)\"," | ||
| } | ||
| headerPathValue += ")" |
There was a problem hiding this comment.
I would suggest just always writing as a list. This can be reduced to:
headerPathValue = "( " + headerPaths.map({ "\"\($0)\"" }).joined(separator: ", ") + " )"
Also, we really need utilities or other infrastructure for writing out structured values with appropriate quoting, etc.
There was a problem hiding this comment.
Yeah that def looks better, updated
| @@ -163,6 +183,7 @@ extension SwiftModule { | |||
| buildSettings["PRODUCT_MODULE_NAME"] = c99name | |||
| buildSettings["OTHER_SWIFT_FLAGS"] = "-DXcode" | |||
| buildSettings["MACOSX_DEPLOYMENT_TARGET"] = "'10.10'" | |||
| buildSettings["LIBRARY_SEARCH_PATHS"] = "/usr/local/lib" | |||
There was a problem hiding this comment.
I thought system modules will probably be present there on darwin, this would be handled better after the "SwiftPM System Module Search Paths" is accepted/implemented. Should I remove this for now?
There was a problem hiding this comment.
K, understood. Yes please remove it, I worry we would forget about this sort of buried setting and then people will come to depend on it and then we can never remove it.
|
@swift-ci Please test |
|
If it passes, let’s squash the history and merge. |
|
CI Passed, squashing and merging |
aciidgh
force-pushed
the
header_search_path_xcodeproj
branch
from
94b97d4 to
1f5f48a
Compare
Fixes https://bugs.swift.org/browse/SR-1085