-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Xcodeproj] Generating clibs targets, beginning #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -99,6 +99,28 @@ public class TestModule: SwiftModule { | |||
} | |||
} | |||
|
|||
public class XcodeModule: Module { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there should be a XcodeModule
since Modules here are things which can be built.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a protocol would be better, XCodeRepresentable
or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to make a protocol. But -G use all Module fields. I made a protocol which copies all Module properties and stopped in
public var dependencies: [Module] /// in build order
Don't remember an error. Also I'm not very good in swift, maybe it possible.
The problem in description is solved. |
Fix Xcode header search paths
Revert "Fix Xcode header search paths"
@mxcl Could you please help with it? What is done:
Where are errors:
I don't have strong xcode background so I can't configure xcode project by hands. If you or somebody else can send me xproj xml, I can reproduce it in code. |
@mxcl I haven't been watching too closely, but it looks like support for C libs in Xcode projects (what this PR is trying to implement) is still not here. #226 gets us half the way there (adding support for module maps) but still does not address the issue of packages with C sources (in the include directory). I know you're very busy doing great work, but its frustrating to have a PR like this that is waiting for guidance from contributors but instead gets ignored for well over a week. |
We have limited bandwidth, like any open source project. It is pretty common for requests to need "pings" when people are busy. Also, if you really want to see this patch make progress then consider seeing if you can provide the necessary review directly! |
I apologize. I am behind and for this specific topic I have reservations. I'll get to it soon. |
@ddunbar: Fair enough! I would help out with the review myself if I had a better understanding of Xcode, along with knowing the direction which you guys would like to take here (for example, I'm still not sure why SPM generates dynamic library targets instead of framework target). @mxcl: Glad to hear that! Patiently waiting 😃 |
I was working on this yesterday, I probably will be able to finish this patch soon today. |
@aciidb0mb3r |
Yes, but if you still want to give it another try feel free. |
I tried to make it with protocols but stopped with .dependecies, which are of Project type. |
@aciidb0mb3r I done it! With templates and |
Look at #235 |
Now
-X
command ignoring c targets and deps. This commit is early beginning, nothing is working.Created PR, because I need help.
Xcode now writes
errors. To reproduce:
It's just an example, it could be other lib
So the question. How I can setup xcode project to build c lib from source and use modulemap as module to export. I just need generated xcodeproj xml, so I can reproduce it in spm code.
Thanks