Add support for newer C++ language standards. #2716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ddunbar
commented
Apr 29, 2020
ddunbar
commented
- This adds support for two newer C++ standards.
* This adds support for two newer C++ standards.
ddunbar
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
|
What do I need to do here w.r.t. package versioning? |
|
You'll need availability annotations. I'm assuming we target 5.3 for this? If this is for post-5.3, we have |
|
@swift-ci please smoke test |
neonichu
approved these changes
Apr 30, 2020
|
Looks good, if this is also going to be merged into the 5.3 branch. If it's just for master, the availability should be |
abertelrud
approved these changes
May 4, 2020
|
Trunk is fine, will change to vNext. |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.