-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update the CLanguageStandard and CXXLanguageStandard enums #3079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The enum cases were generated with: https://gist.github.com/benrimmington/3ca4f22389186766c060d99f05784c1a
The new C17/C18 modes don't seem to differ from C11, but the guiding principle of the SE-0181 review was "supporting all of the non-deprecated GCC/Clang modes". For the deprecated C++1z modes, is the Cc: @ddunbar |
@swift-ci please smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, thanks for this clean-up!
Several of the enum cases have the same comments. From the .def
file it looks as if they are synonyms... should it perhaps be noted in the comments that this is intentional (that it's a synonym?).
Looks as if the self-hosted Linux test fails because of package-collection related unit tests:
|
@swift-ci please smoke test |
Thanks @benrimmington! It does look as if one of the unit test failures is related:
|
@abertelrud I've updated the test assertion and documentation comments, and squashed the commits. I didn't see the test failure locally, because it only gets as far as the guard statement. |
@swift-ci please smoke test |
Great, thanks! |
@swift-ci please smoke test |
Generate the enum cases by preprocessing the LangStandards.def file.
Motivation:
Follow-up to: #2716
Modifications:
Result: