Update PackageDescription.md #3143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benrimmington
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
| # CXXLanguageStandard | ||
|
|
||
| `enum CXXLanguageStandard` | ||
|
|
||
| The supported C++ language standards to use for compiling C++ sources in the package. | ||
| The supported C++ language standard to use for compiling C++ sources in the package. |
There was a problem hiding this comment.
Even if an enum will result on 1 standard, I would keep standards because below we are having a list of standard.
federicobucchi
approved these changes
Dec 26, 2020
|
thanks @benrimmington will merge when we are back next week |
tomerd
approved these changes
Jan 2, 2021
|
@swift-ci please smoke test |
|
Since @tomerd has approved, I will merge as soon as tests pass. |
tomerd
added
the
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the internal documentation.
Motivation:
Follow-up to: #3079
Modifications:
targetmethod toexecutableTarget.CLanguageStandardandCXXLanguageStandardenums.Result: