repair the build after apple/swift-tools-support-core#88 #2875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new parameter seems to trip up the build on Windows. This adds the parameter in explicitly which repairs the build.
compnerd
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
|
Thanks, I didn't realise the TSC PR would break the build. I forgot that TSC CI currently doesn't test SwiftPM, sorry about that. Eventually #2833 will fix it, but this makes sense short term. |
neonichu
approved these changes
Aug 18, 2020
|
@swift-ci please smoke test |
abertelrud
approved these changes
Aug 19, 2020
neonichu
added a commit
to neonichu/swift-package-manager
that referenced
this pull request
Aug 19, 2020
This fixes two issues: - First one is the same as swiftlang#2875 - Second one is a crash related to build conditionals which looks like a longer standing bug that was triggered by swiftlang/swift-llbuild#681 Unforunately, llbuild CI doesn't test the package, so it slipped through and now causes SwiftPM to crash when building itself
neonichu
added a commit
to neonichu/swift-package-manager
that referenced
this pull request
Aug 19, 2020
This fixes two issues: - First one is the same as swiftlang#2875 - Second one is a crash related to build conditionals which looks like a longer standing bug that was triggered by swiftlang/swift-llbuild#681 Unforunately, llbuild CI doesn't test the package, so it slipped through and now causes SwiftPM to crash when building itself
neonichu
added a commit
that referenced
this pull request
Aug 19, 2020
* Unblock SwiftPM's build This fixes two issues: - First one is the same as #2875 - Second one is a crash related to build conditionals which looks like a longer standing bug that was triggered by swiftlang/swift-llbuild#681 Unforunately, llbuild CI doesn't test the package, so it slipped through and now causes SwiftPM to crash when building itself * Sync TSC changes from master
|
#2876 superseded this, since I needed to fix the crasher etc too. |
skarred14
pushed a commit
to val-verde/swift-package-manager
that referenced
this pull request
Aug 26, 2020
* Unblock SwiftPM's build This fixes two issues: - First one is the same as swiftlang#2875 - Second one is a crash related to build conditionals which looks like a longer standing bug that was triggered by swiftlang/swift-llbuild#681 Unforunately, llbuild CI doesn't test the package, so it slipped through and now causes SwiftPM to crash when building itself * Sync TSC changes from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new parameter seems to trip up the build on Windows. This adds the
parameter in explicitly which repairs the build.