Unblock SwiftPM's build #2876
Unblock SwiftPM's build #2876
Conversation
neonichu
requested review from
abertelrud,
aciidgh and
friedbunny
as code owners
|
@swift-ci please smoke test |
This is still here, so I guess this is actually using the superior? Let's disable for now. |
This fixes two issues: - First one is the same as swiftlang#2875 - Second one is a crash related to build conditionals which looks like a longer standing bug that was triggered by swiftlang/swift-llbuild#681 Unforunately, llbuild CI doesn't test the package, so it slipped through and now causes SwiftPM to crash when building itself
|
@swift-ci please smoke test |
|
Oh I get it now, the self-hosting bot uses the superior to build itself, so this PR can't fix it. |
This might be an issue with the vendored copy of TSC not being synced up. |
|
Yes, most likely. You could just remove the |
|
Yah, but then the self-hosted bots will be broken for future PRs. |
|
@swift-ci please smoke test |
|
Right, I just realized that. Syncing is the right way to go. Is there a follow-on fix for llbuild here after things get unbroken (again, many thanks for your work on that!). |
|
Not sure yet, I haven't looked in detail at the llbuild change and if there might be issues with it. |
|
Ugh, my sync was incomplete, I forgot new files. |
|
@swift-ci please smoke test |
|
cc @compnerd |
* Unblock SwiftPM's build This fixes two issues: - First one is the same as swiftlang#2875 - Second one is a crash related to build conditionals which looks like a longer standing bug that was triggered by swiftlang/swift-llbuild#681 Unforunately, llbuild CI doesn't test the package, so it slipped through and now causes SwiftPM to crash when building itself * Sync TSC changes from master
This fixes two issues:
longer standing bug that was triggered by build: define
libllbuild_EXPORTSon Windows swift-llbuild#681Unforunately, llbuild CI doesn't test the package, so it slipped through
and now causes SwiftPM to crash when building itself