[5.3] Fix crash related to build conditionals #2941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a crash related to build conditionals which looks like a longer standing bug that was triggered by swiftlang/swift-llbuild#681 Unforunately, llbuild CI doesn't test the package, so it slipped through and now causes SwiftPM to crash when building itself rdar://problem/67432513
neonichu
requested review from
abertelrud,
aciidgh,
friedbunny and
rballard
as code owners
|
This is a cherry-pick of the second part of #2876, but not the other part since that isn't appropriate for 5.3 |
neonichu
changed the title
|
@swift-ci please test |
abertelrud
approved these changes
Sep 19, 2020
abertelrud
reviewed
Sep 19, 2020
rballard
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash related to build conditionals which looks like a
longer standing bug that was triggered by swiftlang/swift-llbuild#681
Unforunately, llbuild CI doesn't test the package, so it slipped through
and now causes SwiftPM to crash when building itself
rdar://problem/67432513