SR-1298: [swift-test] Allow running specific tests #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,7 +35,7 @@ enum Mode: Argument, Equatable, CustomStringConvertible { | |||
| case "--help", "--usage", "-h": | |||
| self = .Usage | |||
| default: | |||
| return nil | |||
| self = .Run(argument) | |||
There was a problem hiding this comment.
I think that with the removal of the return nil the initializer doesn't need to be failable and throwing anymore.
There was a problem hiding this comment.
|
This is dupe of #266 |
|
@aciidb0mb3r ah yes; didn't come across your PR in Jira. See my change on how to use a test specifier without introducing a flag. |
|
Yeah I tried same thing first but the problem with that is, if you specify a mode it'll fail. |
|
Ah yes; |
|
|
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
[BuildSystem] Enable fast cancellation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift-test -hadvertises the ability to test specific test cases, by passing a specifier. However the specifier is ignored and all tests are run. This change allows passing a specifier which is used. Tested on both OS X and Ubuntu 15.10.See also SR-1298.