Skip to content

SR-1298: [swift-test] Allow running specific tests #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

SR-1298: [swift-test] Allow running specific tests #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/swift-test/usage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ enum Mode: Argument, Equatable, CustomStringConvertible {
case "--help", "--usage", "-h":
self = .Usage
default:
return nil
self = .Run(argument)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that with the removal of the return nil the initializer doesn't need to be failable and throwing anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a protocol requirement: https://github.com/apple/swift-package-manager/blob/cc320afb89a6f2b9e97bb428f02c1733ff8f3427/Sources/OptionsParser/Argument.swift#L18

}
}

Expand Down