[Explicit Module Builds] Skip over binary and systemLibrary targets when generating explicit target build jobs #2939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en generating explicit target build jobs
artemcm
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
artemcm
changed the title
DougGregor
approved these changes
Sep 22, 2020
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System modules will consist of a
.modulemapsomewhere in the filesystem, with the path to that module being either manually-specified on thebuildcommand or computed based on the system module type (apt, brew).Similarly, binary targets will bring in an
.xcframework, the contents of which will be exposed via search paths.In both cases, the dependency scanning action in the driver will be automatically be able to detect such targets' modules.