Skip to content

[Explicit Module Builds] Skip over binary and systemLibrary targets when generating explicit target build jobs #2939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2020
Merged

[Explicit Module Builds] Skip over binary and systemLibrary targets when generating explicit target build jobs #2939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion Sources/Build/ManifestBuilder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,8 +323,20 @@ extension LLBuildManifestBuilder {
// product into its constituent targets.
continue
}
guard target.underlyingTarget.type != .systemModule,
target.underlyingTarget.type != .binary else {
// Much like non-Swift targets, system modules will consist of a modulemap
// somewhere in the filesystem, with the path to that module being either
// manually-specified or computed based on the system module type (apt, brew).
// Similarly, binary targets will bring in an .xcframework, the contents of
// which will be exposed via search paths.
//
// In both cases, the dependency scanning action in the driver will be automatically
// be able to detect such targets' modules.
continue
}
guard let description = plan.targetMap[target] else {
fatalError("Expected description for target: \(target)")
fatalError("Expected description for target \(target)")
}
switch description {
case .swift(let desc):
Expand Down