Skip to content

Skip tests related to ParallelTestsPkgTests #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Skip tests related to ParallelTestsPkgTests #2948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Tests/FunctionalTests/MiscellaneousTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ class MiscellaneousTestCase: XCTestCase {
}

func testSwiftTestParallel() throws {
// <rdar://problem/69448176> Fix and re-enable test related to "ParallelTestsPkg"
try XCTSkip()
Copy link
Contributor

@mattt mattt Oct 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neonichu These try XCTSkip() lines are generating the following errors in Xcode 12:

Result of 'XCTSkip' initializer is unused

No calls to throwing functions occur within 'try' expression

Should these instead be throw XCTSkip()?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #2982


fixture(name: "Miscellaneous/ParallelTestsPkg") { prefix in
// First try normal serial testing.
do {
Expand Down Expand Up @@ -258,6 +261,9 @@ class MiscellaneousTestCase: XCTestCase {
}

func testSwiftTestFilter() throws {
// <rdar://problem/69448176> Fix and re-enable test related to "ParallelTestsPkg"
try XCTSkip()

fixture(name: "Miscellaneous/ParallelTestsPkg") { prefix in
let (stdout, _) = try SwiftPMProduct.SwiftTest.execute(["--filter", ".*1", "-l", "--enable-test-discovery"], packagePath: prefix)
XCTAssertMatch(stdout, .contains("testExample1"))
Expand All @@ -274,6 +280,9 @@ class MiscellaneousTestCase: XCTestCase {
}

func testSwiftTestSkip() throws {
// <rdar://problem/69448176> Fix and re-enable test related to "ParallelTestsPkg"
try XCTSkip()

fixture(name: "Miscellaneous/ParallelTestsPkg") { prefix in
let (stdout, _) = try SwiftPMProduct.SwiftTest.execute(["--skip", "ParallelTestsTests", "-l", "--enable-test-discovery"], packagePath: prefix)
XCTAssertNoMatch(stdout, .contains("testExample1"))
Expand Down Expand Up @@ -414,6 +423,9 @@ class MiscellaneousTestCase: XCTestCase {
}

func testSwiftTestLinuxMainGeneration() throws {
// <rdar://problem/69448176> Fix and re-enable test related to "ParallelTestsPkg"
try XCTSkip()

#if os(macOS)
fixture(name: "Miscellaneous/ParallelTestsPkg") { prefix in
let fs = localFileSystem
Expand Down