Skip tests related to ParallelTestsPkgTests #2948
Conversation
neonichu
requested review from
abertelrud,
aciidgh and
friedbunny
as code owners
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
The only thing I might add would be a bug number or comment tracking the fix, but otherwise it looks good. |
|
I didn't want to put a radar reference into OSS, but looks like we have been doing that in the past as well. |
|
@swift-ci please smoke test |
Yes, Radar numbers are fine, and in fact there is a Radar URL field in JIRA. Alternatively, and perhaps better, this could be a JIRA reference (which would involve creating a JIRA to track the issue). |
We are seeing CI failures of the form: ```/private/var/folders/_8/79jmzf2142z2xydc_01btlx00000gn/T/Miscellaneous_ParallelTestsPkg.s9qJNJ/Miscellaneous_ParallelTestsPkg/Tests/ParallelTestsPkgTests/ParallelTestsFailureTests.swift:1:8: error: compiled module was created by an older version of the compiler; rebuild 'XCTest' and try again: /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib/XCTest.swiftmodule/x86_64-apple-macos.swiftmodule``` Let's skip these tests while we are investigating.
neonichu
force-pushed
the
skip-paralleltestspkg
branch
from
8ad8479 to
8c25f89
Compare
|
Don't think a JIRA brings additional value here since this is something we have to investigate ourselves and the full contents of the radar is already the commit msg / PR description. So I just referenced the radar. |
|
@swift-ci please smoke test |
| @@ -213,6 +213,9 @@ class MiscellaneousTestCase: XCTestCase { | |||
| } | |||
|
|
|||
| func testSwiftTestParallel() throws { | |||
| // <rdar://problem/69448176> Fix and re-enable test related to "ParallelTestsPkg" | |||
| try XCTSkip() | |||
There was a problem hiding this comment.
@neonichu These try XCTSkip() lines are generating the following errors in Xcode 12:
Result of 'XCTSkip' initializer is unused
No calls to throwing functions occur within 'try' expression
Should these instead be throw XCTSkip()?
- we were actually not really skipping a few tests, because I didn't do that correctly in swiftlang#2948 - we need to skip a few additional tests which are using the same functionality (running an inferior `swift test`) Supersedes swiftlang#2982
- we were actually not really skipping a few tests, because I didn't do that correctly in swiftlang#2948 - we need to skip a few additional tests which are using the same functionality (running an inferior `swift test`) Supersedes swiftlang#2982
We are seeing CI failures of the form:
Let's skip these tests while we are investigating.