Fix skipping of tests and skip some additional ones #2984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we were actually not really skipping a few tests, because I didn't do that correctly in swiftlang#2948 - we need to skip a few additional tests which are using the same functionality (running an inferior `swift test`) Supersedes swiftlang#2982
neonichu
requested review from
abertelrud,
aciidgh and
friedbunny
as code owners
|
@swift-ci please smoke test |
abertelrud
approved these changes
Oct 16, 2020
mattt
approved these changes
Oct 16, 2020
federicobucchi
pushed a commit
to federicobucchi/swift-package-manager
that referenced
this pull request
Jan 6, 2021
- we were actually not really skipping a few tests, because I didn't do that correctly in swiftlang#2948 - we need to skip a few additional tests which are using the same functionality (running an inferior `swift test`) Supersedes swiftlang#2982
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that correctly in Skip tests related to ParallelTestsPkgTests #2948
functionality (running an inferior
swift test)Supersedes #2982