Add Build Success Message in Console #2971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicobucchi
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
abertelrud
reviewed
Oct 9, 2020
|
Thank you for putting up this PR! I'm wondering if the message should maybe say "Build Succeeded" or "Build Failed", depending on the outcome? |
federicobucchi
force-pushed
the
add-build-success-message
branch
3 times, most recently
from
fa04557 to
8aca8f9
Compare
|
@swift-ci please smoke test |
abertelrud
reviewed
Oct 19, 2020
federicobucchi
force-pushed
the
add-build-success-message
branch
from
8aca8f9 to
4d4aff4
Compare
|
@swift-ci please smoke test |
abertelrud
reviewed
Oct 20, 2020
abertelrud
reviewed
Oct 20, 2020
federicobucchi
force-pushed
the
add-build-success-message
branch
from
4d4aff4 to
401a671
Compare
rdar://69970428 Add Build Failed message
federicobucchi
force-pushed
the
add-build-success-message
branch
from
401a671 to
c0d8b6b
Compare
|
@swift-ci please smoke test |
abertelrud
approved these changes
Oct 21, 2020
|
Thanks, @federicobucchi. Given that there's some work required in the existing code to make a better message possible, I think it makes sense to merge this now and then do the rest as follow-on PRs. This turned out to be a lot more difficult to implement than anticipated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://69970428
After running
swift buildthe final output could display a ‘success message’ (if the build is successful) and some basic infos about where the generated binaries are located.Currently, after a successful build, it ends with exit code 0 and the output is:
[476/476] Linking swift-packageResult after changes:
Success: