fix "build complete" message #3313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
tomerd
force-pushed
the
fix/build-complete-message
branch
from
4d8b6bb to
95c4baa
Compare
|
@swift-ci please smoke test |
tomerd
commented
Feb 26, 2021
| * Build Completed! | ||
| """ | ||
| } | ||
| break |
neonichu
approved these changes
Feb 26, 2021
tomerd
added
the
ready
tomerd
force-pushed
the
fix/build-complete-message
branch
from
88fc16e to
aa55b5c
Compare
|
@swift-ci please smoke test |
|
Linux smoke test failure looks spurious. |
|
@swift-ci please smoke test linux |
motivation: print "build complete" message reliably changes: * move the logic to printg the "build complete" message to the build complete handler * add tests
tomerd
force-pushed
the
fix/build-complete-message
branch
from
aa55b5c to
5ea78f4
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: print "build complete" message reliably
changes: